Re: [PATCH] sysctl: fix typos in comments

From: Kees Cook
Date: Mon Jul 02 2018 - 14:49:16 EST


On Sun, Jul 1, 2018 at 11:22 AM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Fix a few typos/spellos in kernel/sysctl.c.
>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-Kees

> ---
> kernel/sysctl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-418-rc2.orig/kernel/sysctl.c
> +++ lnx-418-rc2/kernel/sysctl.c
> @@ -222,7 +222,7 @@ static int proc_dopipe_max_size(struct c
> void __user *buffer, size_t *lenp, loff_t *ppos);
>
> #ifdef CONFIG_MAGIC_SYSRQ
> -/* Note: sysrq code uses it's own private copy */
> +/* Note: sysrq code uses its own private copy */
> static int __sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
>
> static int sysrq_sysctl_handler(struct ctl_table *table, int write,
> @@ -1973,13 +1973,13 @@ static void warn_sysctl_write(struct ctl
> }
>
> /**
> - * proc_first_pos_non_zero_ignore - check if firs position is allowed
> + * proc_first_pos_non_zero_ignore - check if first position is allowed
> * @ppos: file position
> * @table: the sysctl table
> *
> * Returns true if the first position is non-zero and the sysctl_writes_strict
> * mode indicates this is not allowed for numeric input types. String proc
> - * hadlers can ignore the return value.
> + * handlers can ignore the return value.
> */
> static bool proc_first_pos_non_zero_ignore(loff_t *ppos,
> struct ctl_table *table)
>



--
Kees Cook
Pixel Security