RE: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

[Naga Sureshkumar Relli]

Hi Linus,

> -----Original Message-----
> From: Linus Walleij [mailto:linus.walleij@xxxxxxxxxx]
> Sent: Monday, July 2, 2018 7:18 PM
> To: Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> Cc: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>; Richard Weinberger <richard@xxxxxx>;
> David Woodhouse <dwmw2@xxxxxxxxxxxxx>; Brian Norris
> <computersforpeace@xxxxxxxxx>; Mark Vasut <marek.vasut@xxxxxxxxx>; Florian Fainelli
> <f.fainelli@xxxxxxxxx>; Markus Mayer <mmayer@xxxxxxxxxxxx>; Roger Quadros
> <rogerq@xxxxxx>; Ladislav Michl <ladis@xxxxxxxxxxxxxx>; ada@xxxxxxxxxxx;
> honghui.zhang@xxxxxxxxxxxx; MiquÃl Raynal <miquel.raynal@xxxxxxxxxxx>; linux-
> mtd@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; nagasureshkumarrelli@xxxxxxxxx;
> Michal Simek <michals@xxxxxxxxxx>
> Subject: Re: [[LINUX PATCH v10] 4/4] mtd: rawnand: pl353: Add basic driver for arm
> pl353 smc nand interface
> 
> On Fri, Jun 29, 2018 at 6:15 AM Naga Sureshkumar Relli <nagasure@xxxxxxxxxx> wrote:
> > > On Thu, Jun 28, 2018 at 2:13 PM Naga Sureshkumar Relli <nagasure@xxxxxxxxxx>
> wrote:
> > >
> > >
> > > > > This driver has the same problem as the other patches:
> > > > > use the ARM_AMBA primecell magic numbers detection, and the PrimeCell bus.
> > > >
> > > > Here the child is NAND controller and the parent is PL353 SMC, so
> > > > do we need to update this also as AMBA driver?
> > >
> > > No, sorry. The parent is spawning another device and you should
> > > indeed use a platform device for that.
> > >
> > Ok, you mean platform driver model is sufficient for both pl353-smc.c and pl353_nand.c
> drivers?
> > Or AMBA model is for pl353-smc and platform driver model is for pl353-nand?
> 
> The latter, AMBA primecell bus for pl353-smc and platform device for the nand subdevice.
> 
> Platform device is for anything that cannot be autodetected with e.g.
> magic hardare numbers, and the first device can be autodetected as a prime cell but not the
> subdevice.
Thanks for your inputs, I already started updating this.
I will send v11.

Thanks,
Naga Sureshkumar Relli.
> 
> Yours,
> Linus Walleij