Re: [PATCH] gnss: fix potential error pointer dereference

[Dan Carpenter]

On Tue, Jul 03, 2018 at 02:11:43PM +0200, Johan Hovold wrote:
> On Tue, Jul 03, 2018 at 02:59:22PM +0300, Dan Carpenter wrote:
> > The gnss_allocate_device() function returns a mix of NULL and error
> > pointers on error.  It should only return one or the other.  Since the
> > callers both check for NULL, I've modified it to return NULL on error.
> > 
> > Fixes: 10f146639fee ("gnss: add receiver type support")
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> 
> Ouch, thanks for catching this!
> 
> I think you got the wrong commit for the fixes tag above, however. That
> should be:
> 
> Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")
> 

Oops.  That's what I intended, yes.  I will resend.

regards,
dan carpenter