Re: [PATCH v2 1/2] IIO: st_accel_i2c.c: Simplify access to driver data

From: Andy Shevchenko
Date: Tue Jul 03 2018 - 17:07:31 EST


On Tue, Jul 3, 2018 at 8:41 AM, Nikolaus Voss
<nikolaus.voss@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Use device_get_match_data API to simplify access to driver data.

..._data()

But. You actually don't use it below.

> Let acpi_device_id table entries point to the same driver data as
> of_device_id table entries and uniquify access to driver data by using
> device_get_match_data API.

> #include <linux/acpi.h>
> #include <linux/i2c.h>
> #include <linux/iio/iio.h>

> +#include <linux/of_device.h>

(linux/property.h)

> + match = of_device_get_match_data(&client->dev);
> + if (!match)
> + match = acpi_device_get_match_data(&client->dev);

What I meant is to simply call

match = device_get_match_data(...);

> + if (match)
> + strlcpy(client->name, match, sizeof(client->name));

--
With Best Regards,
Andy Shevchenko