Re: [PATCH v12 05/13] x86/sgx: architectural structures

[Dave Hansen]

On 07/03/2018 11:19 AM, Jarkko Sakkinen wrote:
> +enum sgx_cpuid {
> +	SGX_CPUID_CAPABILITIES	= 0,
> +	SGX_CPUID_ATTRIBUTES	= 1,
> +	SGX_CPUID_EPC_BANKS	= 2,
> +};

I made a review comment about these last time.  I don't remember
receiving any kind of response from you on it, or seeing it addressed in
these patches in any kind of way.

I've also seen comments from Thomas that sound really familiar such as
the lack of comments on the paging code or the use of a semaphore to
protect things that don't sleep.  I made very, very similar comments on
the last posting.

Is there a reason that those comments were not addressed?