Re: [PATCH] fsi: sbefifo: Add missing mutex_unlock

From: Benjamin Herrenschmidt
Date: Tue Jul 03 2018 - 21:11:17 EST


On Tue, 2018-07-03 at 16:21 -0500, Eddie James wrote:
> There was no unlock of the FFDC mutex.
>
> Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxxxxxxx>

Thanks.

Cheers,
Ben.

> ---
> drivers/fsi/fsi-sbefifo.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 4f076fd..a34ff99 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -194,6 +194,7 @@ static void sbefifo_dump_ffdc(struct device *dev, const __be32 *ffdc,
> }
> dev_warn(dev, "+-------------------------------------------+\n");
> }
> + mutex_unlock(&sbefifo_ffdc_mutex);
> }
>
> int sbefifo_parse_status(struct device *dev, u16 cmd, __be32 *response,