Re: [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore)

From: Ravi Bangoria
Date: Wed Jul 04 2018 - 01:27:10 EST




On 07/04/2018 12:56 AM, Oleg Nesterov wrote:
> On 07/03, Ravi Bangoria wrote:
>>
>> Now about adding ref_ctr_offset into uprobe_consumer. Actually, I
>> didn't want to change the uprobe_consumer definition because it's
>> already exported and tools like systemtap are using it.
>
> So what? Yes, the out-of-tree modules should be updated, but this doesn't
> mean we can add the new features.
>
> And, speaking of systemtap, it already has to do build-time checks to verify
> that uprobe_consumer->ret_handler member exists. So it will need another
> STAPCONF_INODE_REFCNT and that is all.

Ok. let me explore that possibility as well.

Thanks,
Ravi