Re: [PATCH 09/15] Introduce Cadence USBSSP DRD Driver - added debugfs files.

[Greg Kroah-Hartman]

On Tue, Jul 03, 2018 at 08:57:53PM +0100, Pawel Laszczak wrote:
> Signed-off-by: Laszczak Pawel <pawell@xxxxxxxxxxx>
> ---

Again for all of these, you need a changelog text.

>  drivers/usb/usbssp/gadget-debugfs.c | 514 ++++++++++++++++++++++++++++
>  drivers/usb/usbssp/gadget-debugfs.h | 137 ++++++++
>  2 files changed, 651 insertions(+)
>  create mode 100644 drivers/usb/usbssp/gadget-debugfs.c
>  create mode 100644 drivers/usb/usbssp/gadget-debugfs.h
> 
> diff --git a/drivers/usb/usbssp/gadget-debugfs.c b/drivers/usb/usbssp/gadget-debugfs.c
> new file mode 100644
> index 000000000000..c0d1e96728e6
> --- /dev/null
> +++ b/drivers/usb/usbssp/gadget-debugfs.c
> @@ -0,0 +1,514 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * USBSSP device controller driver
> + *
> + * Copyright (C) 2018 Cadence.
> + *
> + * Author: Pawel Laszczak
> + * Some code borrowed from the Linux XHCI driver.

What code was borrowed?  Please acknowledge that copyright.

Also, why isn't Pawel's signed-off-by on this?

thanks,

greg k-h