Re: [PATCH] lightnvm: pblk: mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Wed Jul 04 2018 - 09:01:39 EST




On 07/04/2018 03:07 AM, Matias BjÃrling wrote:
> On 07/03/2018 11:21 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>> ---
>> Â drivers/lightnvm/pblk-core.c | 1 +
>> Â 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ed9cc97..9c93334 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -264,6 +264,7 @@ void pblk_free_rqd(struct pblk *pblk, struct nvm_rq *rqd, int type)
>> ÂÂÂÂÂ switch (type) {
>> ÂÂÂÂÂ case PBLK_WRITE:
>> ÂÂÂÂÂÂÂÂÂ kfree(((struct pblk_c_ctx *)nvm_rq_to_pdu(rqd))->lun_bitmap);
>> +ÂÂÂÂÂÂÂ /* fall through */
>> ÂÂÂÂÂ case PBLK_WRITE_INT:
>> ÂÂÂÂÂÂÂÂÂ pool = &pblk->w_rq_pool;
>> ÂÂÂÂÂÂÂÂÂ break;
>>
>
> Thanks Gustavo. Applied for 4.19.

Thanks, Matias.
--
Gustavo