Re: [PATCH v7 1/4] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

[Dmitry Torokhov]

Hi Enric,

On Tue, Jun 26, 2018 at 11:06:33AM +0200, Enric Balletbo Serra wrote:
> Hi Matti,
> 
> Thanks for the patch, a few comments below, some are feedback I
> received when I sent some patches to this subsystem.
> 
> Missatge de Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> del
> dia dt., 19 de juny 2018 a les 12:57:
> > +};
> > +
> > +/* bd71837 multi function cells */
> > +static struct mfd_cell bd71837_mfd_cells[] = {
> > +       {
> > +               .name = "bd71837-clk",
> > +       }, {
> > +               .name = "bd718xx-pwrkey",
> > +               .resources = &irqs[0],
> > +               .num_resources = ARRAY_SIZE(irqs),
> > +       }, {
> > +               .name = "bd71837-pmic",
> > +       },
> nit: no comma at the end

Actually, trailing comma is preferred on structures/arrays without
sentinels, because if one needs to add a new entry/new member, then in
the diff there will have only one new line added, instead of one line
being changed (adding now necessary comma) and one added.

Thanks.

-- 
Dmitry