Re: [PATCH v2 0/4] Assigning NULL to gfn of dax_direct_access if useless

From: Huaisheng Ye
Date: Wed Jul 04 2018 - 12:56:08 EST






---- On Thu, 05 Jul 2018 00:48:40 +0800 Dan Williams <dan.j.williams@xxxxxxxxx> wrote ----
> On Wed, Jul 4, 2018 at 9:38 AM, Huaisheng Ye <yehs2007@xxxxxxxx> wrote:
> > From: Huaisheng Ye <yehs1@xxxxxxxxxx>
> >
> > Changes since v1 [1]:
> > * Collect Jan's reviewed-by.
> > * According to Dan's suggestion, update the unit test infrastructure
> > tools/testing/nvdimm/pmem-dax.c for checking the validity of gfn.
> >
> > [1]: https://lkml.org/lkml/2018/7/4/81
> >
> > ---
> >
> > Some functions within fs/dax don't need to get gfn from direct_access.
>
> Any reason you are calling it 'gfn'? I'm assuming that is a typo and
> it should be 'pfn'.

Oh, sorry.
I made a mistake, it is a typo. I will correct it right now.

---
Cheers,
Huaisheng Ye