RE: [PATCH] platform/mellanox: Use 2-factor allocator calls

[Vadim Pasternak]

> -----Original Message-----
> From: Kees Cook [mailto:keescook@xxxxxxxxxxxx]
> Sent: Wednesday, July 04, 2018 8:29 PM
> To: Darren Hart <dvhart@xxxxxxxxxxxxx>
> Cc: Vadim Pasternak <vadimp@xxxxxxxxxxxx>; Andy Shevchenko
> <andy@xxxxxxxxxxxxx>; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] platform/mellanox: Use 2-factor allocator calls
> 
> As already done treewide, switch from open-coded multiplication to using 2-
> factor allocation helpers.
> 
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Acked-by: Vadim Pasternak <vadimp@xxxxxxxxxxxx>

> ---
>  drivers/platform/mellanox/mlxreg-io.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/mlxreg-io.c
> b/drivers/platform/mellanox/mlxreg-io.c
> index c192dfe6bd65..acfaf64ffde6 100644
> --- a/drivers/platform/mellanox/mlxreg-io.c
> +++ b/drivers/platform/mellanox/mlxreg-io.c
> @@ -152,8 +152,8 @@ static int mlxreg_io_attr_init(struct mlxreg_io_priv_data
> *priv)  {
>  	int i;
> 
> -	priv->group.attrs = devm_kzalloc(&priv->pdev->dev,
> -					 priv->pdata->counter *
> +	priv->group.attrs = devm_kcalloc(&priv->pdev->dev,
> +					 priv->pdata->counter,
>  					 sizeof(struct attribute *),
>  					 GFP_KERNEL);
>  	if (!priv->group.attrs)
> --
> 2.17.1
> 
> 
> --
> Kees Cook
> Pixel Security