Re: [PATCH] mm/memblock: replace u64 with phys_addr_t where appropriate

[Mike Rapoport]

On Wed, Jul 04, 2018 at 10:22:32AM -0700, Joe Perches wrote:
> On Wed, 2018-07-04 at 10:03 +0300, Mike Rapoport wrote:
> > On Tue, Jul 03, 2018 at 01:24:07PM -0700, Joe Perches wrote:
> > > On Tue, 2018-07-03 at 12:57 -0700, Andrew Morton wrote:
> > > > Did you see all this checkpatch noise?
> > > > 
> > > > : WARNING: Deprecated vsprintf pointer extension '%pF' - use %pS instead
> > > > : #54: FILE: mm/memblock.c:1348:
> > > > : +	memblock_dbg("%s: %llu bytes align=0x%llx nid=%d from=%pa max_addr=%pa %pF\n",
> > > > : +		     __func__, (u64)size, (u64)align, nid, &min_addr,
> > > > : +		     &max_addr, (void *)_RET_IP_);
> > > > : ...
> > > 
> > > %p[Ff] got deprecated by commit 04b8eb7a4ccd9ef9343e2720ccf2a5db8cfe2f67
> > > 
> > > I think it'd be simplest to just convert
> > > all the %pF and %pf uses all at once.
> > > 
> > > $ git grep --name-only "%p[Ff]" | \
> > >   xargs sed -i -e 's/%pF/%pS/' -e 's/%pf/%ps/'
> > > 
> > > and remove the appropriate Documentation bit.
> > > 
> > 
> > Something like this:
> 
> not quite as you either need to run the command
> multiple times or use

You are right. I've just blindly copied the command from email without
thinking :(
 
> $ git grep --name-only "%p[Ff]" | \
>   xargs sed -i -e 's/%pF/%pS/g' -e 's/%pf/%ps/g'

Here's the updated version: