Re: [PATCH] net: ethernet: sun: remove redundant variables adv and lpa

From: David Miller
Date: Thu Jul 05 2018 - 06:33:24 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 5 Jul 2018 10:37:32 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Variables adv and lpa are being assigned but are never used hence they
> are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'lpa' set but not used [-Wunused-but-set-variable]
> warning: variable 'adv' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

I think you can safely remove the register reads too, so please
do so.

Thanks.