Re: [PATCH net-next 6/8] virtio: introduce packed ring defines

[Jason Wang]

On 2018å07æ05æ 04:15, Maxime Coquelin wrote:
> On 07/03/2018 07:38 AM, Jason Wang wrote:
> > diff --git a/include/uapi/linux/virtio_ring.h 
> > b/include/uapi/linux/virtio_ring.h
> > index 6d5d5fa..71c7a46 100644
> > --- a/include/uapi/linux/virtio_ring.h
> > +++ b/include/uapi/linux/virtio_ring.h
> > @@ -43,6 +43,8 @@
> > Â #define VRING_DESC_F_WRITEÂÂÂ 2
> > Â /* This means the buffer contains a list of buffer descriptors. */
> > Â #define VRING_DESC_F_INDIRECTÂÂÂ 4
> > +#define VRING_DESC_F_AVAILÂÂÂÂÂ 7
> > +#define VRING_DESC_F_USEDÂÂÂ 15
>
> For consistency, you may want to make VRING_DESC_F_AVAIL and 
> VRING_DESC_F_USED to represent the bit mask and not the bit position,
> as done for VRING_DESC_F_WRITE and VRING_DESC_F_INDIRECT.
>
> Regards,
> Maxime

Yes, Tiwei has the same comment.

Will fix this.

Thanks