Re: [PATCH 3/3] drivers/speakup: Fix style and coding warnings

[Dan Carpenter]

On Wed, Jul 04, 2018 at 10:46:05PM +0300, Tamir Suliman wrote:
> 
> Interesting construct...  Yeah I'm little bit rusty on my C /programming  .
> I understand  proper coding style may be should end with else so I wasn't
> sure .. however this resolved the warnings. :)


The code you wrote was very wrong.

It doesn't compile.  You need to figure out what is wrong with your
testing so that it doesn't happen again.

regards,
dan carpenter