Re: [PATCH v11 1/2] Refactor part of the oom report in dump_header

From: Andy Shevchenko
Date: Thu Jul 05 2018 - 08:24:43 EST


On Thu, Jul 5, 2018 at 2:23 PM, çèé <ufo19890607@xxxxxxxxx> wrote:
> Hi Michal and Andy

> The enum oom_constraint will be added in the struct oom_control. So
> I still think I should define it in oom.h.

You missed the point. I'm talking about an array of string literals.
Please, check what the warning I got from the compiler.

> Michal Hocko <mhocko@xxxxxxxxxx> ä2018å7æ4æåä äå4:17åéï
>>
>> On Wed 04-07-18 10:25:30, çèé wrote:
>> > Hi Andy
>> > The const char array need to be used by the new func
>> > mem_cgroup_print_oom_context and some funcs in oom_kill.c in the
>> > second patch.
>>
>> Just declare it in oom.h and define in oom.c
>> --
>> Michal Hocko
>> SUSE Labs



--
With Best Regards,
Andy Shevchenko