Re: [PATCH v2 3/4] RISC-V: Add definiion of extract symbol's index and type for 32-bit

[Palmer Dabbelt]

On Thu, 05 Jul 2018 06:33:07 PDT (-0700), zongbox@xxxxxxxxx wrote:
> Palmer Dabbelt <palmer@xxxxxxxxxx> æ 2018å7æ5æ éå äå4:58åéï
> > On Fri, 29 Jun 2018 09:53:49 PDT (-0700), zongbox@xxxxxxxxx wrote:
> > > Christoph Hellwig <hch@xxxxxxxxxxxxx> æ 2018å6æ29æ éä äå3:12åéï
> > >>
> > >> On Mon, Jun 25, 2018 at 04:49:39PM +0800, Zong Li wrote:
> > >> > Use generic marco to get the index and type of symbol.
> > >>
> > >> Why do we even need this in a uapi header?  Shouldn't ELF_RISCV_R_SYM
> > >> and ELF_RISCV_R_TYPE move to module.c?  In that case we could just
> > >> use CONFIG_64BIT.
> > >
> > > Make sense. I even think the all definitions can be move to include/asm/elf.h.
> > > How do you think about that?
> >
> > Sorry I've been slow about reviewing this, but I think just in the interest of
> > getting a sane RV32I port up and running quickly (so we can try to get glibc in
> > shape) I'm going to take this for now.
> >
> > Do you mind submitting a cleanup patch?
>
> I will send a patch to clean up. Thanks everyone to review this patchset.

Well, thanks for doing the work :).