Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property

[Robert P. J. Day]

On Thu, 5 Jul 2018, Rob Herring wrote:

> On Mon, Jul 02, 2018 at 05:12:19PM +0800, alanx.chiang@xxxxxxxxx wrote:
> > From: Alan Chiang <alanx.chiang@xxxxxxxxx>
> >
> > The AT24 series chips use 8-bit address by default. If some
> > chips would like to support more than 8 bits, the at24 driver
> > should be added the compatible field for specfic chips.
> >
> > Provide a flexible way to determine the addressing bits through
> > address-width in this patch.
> >
> > Signed-off-by: Alan Chiang <alanx.chiang@xxxxxxxxx>
> > Signed-off-by: Andy Yeh <andy.yeh@xxxxxxxxx>
> > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> >
> > ---
> > since v1:
> > -- Remove the address-width field in the example.
> > since v2:
> > -- Remove redundant space.
> > since v3:
> > -- Add Acked-by.
> >
> > ---
> >  Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> >  1 file changed, 2 insertions(+)
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

  "... should be added the compatible field ..."??

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================