Re: [PATCH v7 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings

[Stanley Chu]

On Thu, 2018-07-05 at 15:15 -0600, Rob Herring wrote:
> On Thu, Jul 05, 2018 at 09:09:28AM +0800, Stanley Chu wrote:

Hi Rob,

> > +- reg: Should contain location and length for timer register.
> > +- clocks: Both timers are driven by system clock.
> 
> The binding just needs to say how many clocks, what they are and the 
> order.
> 
> You need to explain in the commit message why you remove the RTC clock.

OK! Will fix binding description and commit message in v8.

RTC clock is not used in both "GPT" and "SYST" driver now so we just
remove it.

> 
> >  
> >  Examples:
> >  
> > @@ -21,5 +27,5 @@ Examples:
> >  		compatible = "mediatek,mt6577-timer";
> >  		reg = <0x10008000 0x80>;
> >  		interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_LOW>;
> > -		clocks = <&system_clk>, <&rtc_clk>;
> > -	};
> > +		clocks = <&system_clk>;
> > +	};
> > \ No newline at end of file
> 
> Fix this.

Will fix it in v8.

Thanks.
Stanley Chu

> 
> > -- 
> > 1.7.9.5
> >