Re: [PATCH] ipv4: Return EINVAL when ping_group_range sysctl doesn't map to user ns

[David Miller]

From: Tyler Hicks <tyhicks@xxxxxxxxxxxxx>
Date: Thu,  5 Jul 2018 18:49:23 +0000

> The low and high values of the net.ipv4.ping_group_range sysctl were
> being silently forced to the default disabled state when a write to the
> sysctl contained GIDs that didn't map to the associated user namespace.
> Confusingly, the sysctl's write operation would return success and then
> a subsequent read of the sysctl would indicate that the low and high
> values are the overflowgid.
> 
> This patch changes the behavior by clearly returning an error when the
> sysctl write operation receives a GID range that doesn't map to the
> associated user namespace. In such a situation, the previous value of
> the sysctl is preserved and that range will be returned in a subsequent
> read of the sysctl.
> 
> Signed-off-by: Tyler Hicks <tyhicks@xxxxxxxxxxxxx>

Looks good to me, applied and queued up for -stable.

Thanks.