Re: [PATCH] sched/core: remove get_cpu() from sched_fork()

From: Sebastian Andrzej Siewior
Date: Fri Jul 06 2018 - 09:32:07 EST


On 2018-07-06 15:18:08 [+0200], Peter Zijlstra wrote:
> On Fri, Jul 06, 2018 at 03:06:15PM +0200, Sebastian Andrzej Siewior wrote:
> > Based on this it is possible to remove get_cpu() and use
> > smp_processor_id() for the `cpu' variable without breaking anything.
>
> Almost.. I think, see init_task_preempt_count().

#define init_task_preempt_count(p) do { \
task_thread_info(p)->preempt_count = FORK_PREEMPT_COUNT; \
} while (0)

and task_thread_info() references p only. It looks good, what did I
miss?

Sebastian