Re: [PATCH] x86/crypto: Add missing RETs
From: Ingo Molnar
Date: Fri Jul 06 2018 - 10:57:46 EST
* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > Great, I'd be perfectly fine with such an approach.
> >
> > Also, if we have that then we could re-apply Alexey's patch and switch to INT3
> > (only on 64-bit kernels) without any trouble, because objtool should detect any
> > execution flow bugs before the INT3 could trigger, right?
> >
> > I.e. any INT3 fault would show a combination of *both* an objtool bug and a
> > probable code flow bug - which I suspect would warrant crashing the box ...
>
> Sounds good to me. I can take Alexey's patch and submit a 64-bit
> version of it, along with the relevant objtool changes (though it may
> still be a few weeks before I get the chance).
Sounds good to me, thanks!
Ingo