RE: [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment.

From: Thomas Gleixner
Date: Fri Jul 06 2018 - 13:02:03 EST


On Fri, 6 Jul 2018, Michael Kelley (EOSG) wrote:
> > -----Original Message-----
> > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Sent: Friday, July 6, 2018 3:42 AM
> > To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>; x86@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
> > jasowang@xxxxxxxxxx; hpa@xxxxxxxxx; Stephen Hemminger <sthemmin@xxxxxxxxxxxxx>;
> > Michael Kelley (EOSG) <Michael.H.Kelley@xxxxxxxxxxxxx>; vkuznets@xxxxxxxxxx
> > Subject: RE: [PATCH 1/1] X86/Hyper-V:: Fix the circular dependency in IPI enlightenment.

Can you please strip that useless duplication of the mail header from your
replies. Manualy if you can't teach your MUA to avoid that :)

> > On Fri, 6 Jul 2018, Thomas Gleixner wrote:
> > Applied it to x86/urgent and fixed up the '-1' sloppy hack as pointed out
> > by Vitaly and merged x86/urgent into x86/hyperv.
> >
> > Please check both branches for correctness.
>
> Changes look good to me. Some pre-existing signed/unsigned type sloppiness is
> still there in that hv_cpu_number_to_vp_number() should be 'u32' instead
> of 'int', along with related local variables, but that's probably best to fix in
> linux-next on top of Vitaly's other changes. This code will work.

Yes, delta patch is fine on top of x86/hyperv.

Thanks,

tglx