Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register_clock()

[Thomas Gleixner]

On Fri, 6 Jul 2018, Paolo Bonzini wrote:

> Decrapification went a bit too far...
> 
> On 06/07/2018 18:13, Thomas Gleixner wrote:
> > -	int cpu = smp_processor_id();
> > -	int low, high, ret;
> >  	struct pvclock_vcpu_time_info *src;
> > +	int cpu = smp_processor_id();
> > +	u64 pa;
> >  
> >  	if (!hv_clock)
> > -		return 0;
> > -
> > -	src = &hv_clock[cpu].pvti;
> 
> ... the line above should not have been a "-".  That, or initialize it
> in the declaration.  Whoever applies can fix it, no need to repost.
> I'll test with the above fix.

Indeed.