Re: [PATCH] [net-next] devlink: fix incorrect return statement

From: David Miller
Date: Sat Jul 07 2018 - 07:07:27 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Fri, 6 Jul 2018 14:58:51 +0200

> A newly added dummy helper function tries to return a failure from a "void"
> function:
>
> In file included from include/net/dsa.h:24,
> from arch/arm/plat-orion/common.c:21:
> include/net/devlink.h: In function 'devlink_param_value_changed':
> include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror]
> return -EOPNOTSUPP;
>
> This fixes it by removing the bogus statement.
>
> Fixes: ea601e170988 ("devlink: Add devlink notifications support for params")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Applied.