Re: [PATCH net 1/1] net/smc: reduce sock_put() for fallback sockets

[David Miller]

From: Ursula Braun <ubraun@xxxxxxxxxxxxx>
Date: Thu,  5 Jul 2018 16:15:30 +0200

> smc_release() calls a sock_put() for smc fallback sockets to cover
> the passive closing sock_hold() in __smc_connect() and
> smc_tcp_listen_work(). This does not make sense for sockets in state
> SMC_LISTEN and SMC_INIT.
> An SMC socket stays in state SMC_INIT if connect fails. The sock_put
> in smc_connect_abort() does not cover all failures. Move it into
> smc_connect_decline_fallback().
> 
> Fixes: ee9dfbef02d18 ("net/smc: handle sockopts forcing fallback")
> Reported-by: syzbot+3a0748c8f2f210c0ef9b@xxxxxxxxxxxxxxxxxxxxxxxxx
> Reported-by: syzbot+9e60d2428a42049a592a@xxxxxxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Ursula Braun <ubraun@xxxxxxxxxxxxx>

Applied, thanks.