Re: [PATCH] mei: bus: type promotion bug in mei_nfc_if_version()

From: Greg Kroah-Hartman
Date: Sat Jul 07 2018 - 11:33:05 EST


On Wed, Jul 04, 2018 at 12:34:49PM +0300, Dan Carpenter wrote:
> We accidentally removed the check for negative returns without
> considering the issue of type promotion. The "if_version_length"
> variable is type size_t so if __mei_cl_recv() returns a negative then
> "bytes_recv" is type promoted to a high positive value and treated as
> success.
>
> Fixes: 582ab27a063a ("mei: bus: fix received data size check in NFC fixup")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Didn't apply to my tree at all :(