Yes we can add driver data in ACPI ID as well so code can be:
if (!has_acpi_companion(&pdev->dev)) {
rng->clk = devm_clk_get(&pdev->dev, "core");
if (IS_ERR(rng->clk))
return PTR_ERR(rng->clk);
}
rng->skip_init = device_get_match_data(&pdev->dev);
Looks much neater.
I will wait for feedback on other patches before updating this.