Re: [PATCH] net: usb: hso: use swap macro in hso_kick_transmit

[Gustavo A. R. Silva]

Hi David,

On 07/12/2018 12:58 AM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
> Date: Mon, 9 Jul 2018 10:40:48 -0500
> 
>> @@ -1748,14 +1747,11 @@ static void hso_kick_transmit(struct hso_serial *serial)
>>  		goto out;
>>  
>>  	/* Switch pointers around to avoid memcpy */
>> -	temp = serial->tx_buffer;
>> -	serial->tx_buffer = serial->tx_data;
>> -	serial->tx_data = temp;
>> +	swap(serial->tx_buffer, serial->tx_data);
>>  	serial->tx_data_count = serial->tx_buffer_count;
>>  	serial->tx_buffer_count = 0;
>>  
>> -	/* If temp is set, it means we switched buffers */
>> -	if (temp && serial->write_data) {
>> +	if (serial->write_data) {
> 
> I think temp can be NULL here, you have to retain this check.
> 

I see. Well, in that case I will check serial->tx_data instead.

Thanks for the feedback.
--
Gustavo