Re: [PATCH] base: core: Remove WARN_ON from link dependencies check

From: Rafael J. Wysocki
Date: Mon Jul 16 2018 - 05:46:52 EST


On Thursday, July 12, 2018 11:18:26 AM CEST Benjamin Gaignard wrote:
> 2018-07-12 10:55 GMT+02:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> > On Thu, Jul 12, 2018 at 10:06:23AM +0200, Benjamin Gaignard wrote:
> >> In some cases the link between between customer and supplier
> >> already exist. Do not warn about already existing dependencies
> >> because device_link_add() take care of this case.
> >
> > Why would a link already exist that is asked to be created again? What
> > code path causes this?
>
> It could happen that the link exist because a device use it parent as supplier.
> That case has been describe by Marek in this thread (I forgot to add
> it in the commit message, sorry):
> https://lkml.org/lkml/2018/7/9/356

So please add this information to the patch changelog and resend.

Thanks,
Rafael