Re: [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort()

[Punit Agrawal]

Hi Suzuki,

Suzuki K Poulose <Suzuki.Poulose@xxxxxxx> writes:

> On 16/07/18 12:08, Punit Agrawal wrote:
>> The code for operations such as marking the pfn as dirty, and
>> dcache/icache maintenance during stage 2 fault handling is duplicated
>> between normal pages and PMD hugepages.
>>
>> Instead of creating another copy of the operations when we introduce
>> PUD hugepages, let's share them across the different pagesizes.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@xxxxxxx>
>> Cc: Christoffer Dall <christoffer.dall@xxxxxxx>
>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
>
> Thanks for splitting the patch. It looks much simpler this way.
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>

Thanks for reviewing the patches.

Punit

> _______________________________________________
> kvmarm mailing list
> kvmarm@xxxxxxxxxxxxxxxxxxxxx
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm