Re: [PATCH] [RESEND] perf/x86/intel/uncore: Fix the index of PCU.3 Broadwell CPUs

[Masayoshi Mizuma]

On 07/16/2018 10:29 AM, Liang, Kan wrote:
> 
> 
> On 7/15/2018 6:34 PM, Ingo Molnar wrote:
>>
>> * Masayoshi Mizuma <msys.mizuma@xxxxxxxxx> wrote:
>>
>>> From: Masayoshi Mizuma <m.mizuma@xxxxxxxxxxxxxx>
>>>
>>> commit 15a3e845b01c ("perf/x86/intel/uncore: Fix SBOX support for
>>> Broadwell CPUs") introduced PCU.3 for Broadwell CPU. Unfortunately,
>>> the driver_data of PCU.3 conflicts to QPI Port 2 filter.
>>>
>>>  { /* QPI Port 2 filter */
>>> ÂÂÂÂÂÂÂÂÂÂÂÂ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x6f46),
>>> ÂÂÂÂÂÂÂÂÂÂÂÂ .driver_data = UNCORE_PCI_DEV_DATA(UNCORE_EXTRA_PCI_DEV, 2),
>>>
>>> ÂÂÂÂ { /* PCU.3 (for Capability registers) */
>>> ÂÂÂÂÂÂÂÂÂÂÂÂ PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x6fc0),
>>> ÂÂÂÂÂÂÂÂÂÂÂÂ .driver_data = UNCORE_PCI_DEV_DATA(UNCORE_EXTRA_PCI_DEV,
>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ HSWEP_PCI_PCU_3),
>>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ // HSWEP_PCI_PCU_3 == 2
>>
>>> --- a/arch/x86/events/intel/uncore_snbep.c
>>> +++ b/arch/x86/events/intel/uncore_snbep.c
>>> @@ -1030,6 +1030,7 @@ enum {
>>> ÂÂÂÂÂ SNBEP_PCI_QPI_PORT0_FILTER,
>>> ÂÂÂÂÂ SNBEP_PCI_QPI_PORT1_FILTER,
>>> ÂÂÂÂÂ HSWEP_PCI_PCU_3,
>>> +ÂÂÂ BDX_PCI_PCU_3,
>>> Â };
>>
>> So we use a magic '2' enumerator in the 'QPI Port 2 filter', and that overlaps
>> with HSWEP_PCI_PCU_3, right?
>>
>> Shouldn't we clean up all the enumerators and not use magic numbers, and this fix
>> the conflict?
>>
> 
> Yes, it should fix the conflict. I will clean up the code.

Thanks a lot!
I would appreciate if you could add CC to me when you post the patch.

Thanks,
Masa 

> 
> Thanks,
> Kan
> 
> 
>> Thanks,
>>
>> ÂÂÂÂIngo
>>