Re: [PATCH v3 1/1] drm/panel: Add support for Olimex LCD-OLinuXino panel

From: Rob Herring
Date: Mon Jul 16 2018 - 11:08:42 EST


On Thu, Jul 12, 2018 at 11:21:53AM +0300, Stefan Mavrodiev wrote:
> This patch adds Olimex Ltd. LCD-OLinuXino bridge panel driver. The
> panel is used with different LCDs (currently from 480x272 to 1280x800).
> Small EEPROM chip is used for identification, which holds some
> factory data and timing requirements.
>
> Signed-off-by: Stefan Mavrodiev <stefan@xxxxxxxxxx>
> ---
> Changes for v3:
> - Change module license from "GPL v2" to "GPL"
> - Make use of backlight_enable()/backlight_disable() helpers
> - Rework backlight device request
> - Remove drm_panel_detach()
> - Use module_i2c_driver() for initialization
> - Make the first mode preferred
> - If num_modes value is invalid, overwrite it with 4, which is the maximum
> - Some variable types optimizations
>
> Changes for v2:
> - Changed lcd_olinuxino_funcs to static const
>
> .../display/panel/olimex,lcd-olinuxino.txt | 42 +++

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> MAINTAINERS | 6 +
> drivers/gpu/drm/panel/Kconfig | 10 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 331 +++++++++++++++++++++
> 5 files changed, 390 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/olimex,lcd-olinuxino.txt
> create mode 100644 drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c