[PATCH v2 12/14] libnvdimm, pmem: Initialize the memmap in the background
From: Dan Williams
Date: Mon Jul 16 2018 - 13:11:26 EST
Arrange for the pmem driver to call memmap_sync() when it is asked to
produce a valid pfn. The infrastructure is housed in the 'nd_pfn'
device which implies that the async init support only exists for
platform defined persistent memory, not the legacy / debug memmap=ss!nn
facility.
Another reason to restrict the capability to the 'nd_pfn' device case is
that nd_pfn devices have sysfs infrastructure to communicate the
memmap initialization state to userspace.
The sysfs publication of memmap init state is saved for a later patch.
Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx>
Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
---
drivers/nvdimm/nd.h | 2 ++
drivers/nvdimm/pmem.c | 16 ++++++++++++----
drivers/nvdimm/pmem.h | 1 +
tools/testing/nvdimm/pmem-dax.c | 7 ++++++-
4 files changed, 21 insertions(+), 5 deletions(-)
diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h
index 32e0364b48b9..ee4f76fb0cb5 100644
--- a/drivers/nvdimm/nd.h
+++ b/drivers/nvdimm/nd.h
@@ -12,6 +12,7 @@
*/
#ifndef __ND_H__
#define __ND_H__
+#include <linux/memmap_async.h>
#include <linux/libnvdimm.h>
#include <linux/badblocks.h>
#include <linux/blkdev.h>
@@ -208,6 +209,7 @@ struct nd_pfn {
unsigned long npfns;
enum nd_pfn_mode mode;
struct nd_pfn_sb *pfn_sb;
+ struct memmap_async_state async;
struct nd_namespace_common *ndns;
};
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index c430536320a5..a1158181adc2 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -22,6 +22,7 @@
#include <linux/platform_device.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
+#include <linux/memmap_async.h>
#include <linux/badblocks.h>
#include <linux/memremap.h>
#include <linux/vmalloc.h>
@@ -228,8 +229,13 @@ __weak long __pmem_direct_access(struct pmem_device *pmem, pgoff_t pgoff,
PFN_PHYS(nr_pages))))
return -EIO;
*kaddr = pmem->virt_addr + offset;
- if (pfn)
+ if (pfn) {
+ struct dev_pagemap *pgmap = &pmem->pgmap;
+ struct memmap_async_state *async = pgmap->async;
+
*pfn = phys_to_pfn_t(pmem->phys_addr + offset, pmem->pfn_flags);
+ memmap_sync(*pfn, nr_pages, async);
+ }
/*
* If badblocks are present, limit known good range to the
@@ -310,13 +316,15 @@ static void fsdax_pagefree(struct page *page, void *data)
wake_up_var(&page->_refcount);
}
-static int setup_pagemap_fsdax(struct device *dev, struct dev_pagemap *pgmap)
+static int setup_pagemap_fsdax(struct device *dev, struct dev_pagemap *pgmap,
+ struct memmap_async_state *async)
{
dev_pagemap_get_ops();
if (devm_add_action_or_reset(dev, pmem_release_pgmap_ops, pgmap))
return -ENOMEM;
pgmap->type = MEMORY_DEVICE_FS_DAX;
pgmap->page_free = fsdax_pagefree;
+ pgmap->async = async;
return 0;
}
@@ -379,7 +387,7 @@ static int pmem_attach_disk(struct device *dev,
pmem->pfn_flags = PFN_DEV;
pmem->pgmap.ref = &q->q_usage_counter;
if (is_nd_pfn(dev)) {
- if (setup_pagemap_fsdax(dev, &pmem->pgmap))
+ if (setup_pagemap_fsdax(dev, &pmem->pgmap, &nd_pfn->async))
return -ENOMEM;
addr = devm_memremap_pages(dev, &pmem->pgmap,
pmem_freeze_queue);
@@ -393,7 +401,7 @@ static int pmem_attach_disk(struct device *dev,
} else if (pmem_should_map_pages(dev)) {
memcpy(&pmem->pgmap.res, &nsio->res, sizeof(pmem->pgmap.res));
pmem->pgmap.altmap_valid = false;
- if (setup_pagemap_fsdax(dev, &pmem->pgmap))
+ if (setup_pagemap_fsdax(dev, &pmem->pgmap, NULL))
return -ENOMEM;
addr = devm_memremap_pages(dev, &pmem->pgmap,
pmem_freeze_queue);
diff --git a/drivers/nvdimm/pmem.h b/drivers/nvdimm/pmem.h
index a64ebc78b5df..93d226ea1006 100644
--- a/drivers/nvdimm/pmem.h
+++ b/drivers/nvdimm/pmem.h
@@ -1,6 +1,7 @@
/* SPDX-License-Identifier: GPL-2.0 */
#ifndef __NVDIMM_PMEM_H__
#define __NVDIMM_PMEM_H__
+#include <linux/memmap_async.h>
#include <linux/badblocks.h>
#include <linux/types.h>
#include <linux/pfn_t.h>
diff --git a/tools/testing/nvdimm/pmem-dax.c b/tools/testing/nvdimm/pmem-dax.c
index d4cb5281b30e..63151b75615c 100644
--- a/tools/testing/nvdimm/pmem-dax.c
+++ b/tools/testing/nvdimm/pmem-dax.c
@@ -42,8 +42,13 @@ long __pmem_direct_access(struct pmem_device *pmem, pgoff_t pgoff,
}
*kaddr = pmem->virt_addr + offset;
- if (pfn)
+ if (pfn) {
+ struct dev_pagemap *pgmap = &pmem->pgmap;
+ struct memmap_async_state *async = pgmap->async;
+
*pfn = phys_to_pfn_t(pmem->phys_addr + offset, pmem->pfn_flags);
+ memmap_sync(*pfn, nr_pages, async);
+ }
/*
* If badblocks are present, limit known good range to the