Re: [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig

[Randy Dunlap]

On 07/16/2018 09:55 AM, Coly Li wrote:
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> This patch adds crc64 option entry in lib/Kconfig. This patch is part of
> a patch originally written by Andy Shevchenko, Coly Li cherry-picks it
> and compose the commit log for a re-written crc64 source code.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Coly Li <colyli@xxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Luis R. Rodriguez <mcgrof@xxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>
> ---
>  lib/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 706836ec314d..4059df9ec4c7 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -170,6 +170,14 @@ config CRC32_BIT
>  
>  endchoice
>  
> +config CRC64
> +	tristate "CRC64 functions"
> +	help
> +	  This option is provided for the case where no in-kernel-tree
> +	  modules require CRC64 functions, but a module built outside
> +	  the kernel tree does. Such modules that use library CRC64
> +	  functions require M he

eh?  missing something here.

> +
>  config CRC4
>  	tristate "CRC4 functions"
>  	help
> 


-- 
~Randy