Re: [PATCH v3] time: Fix incorrect sleeptime injection when suspend fails

[Thomas Gleixner]

On Tue, 17 Jul 2018, Mukesh Ojha wrote:
> On 7/16/2018 10:44 PM, John Stultz wrote:
> > > So, I think with the logic bug above it will work out properly, but
> > > let me know if I'm still missing something.
> 
> Please give it thought to a case where very first suspend fails with your
> logic.
> If i am not able to get your thought, please write a patch.

John wants you to invert the logic. i.e.

     true -> false
     false -> true
     if (var) -> if (!var)
     if (!var) -> if (var)

It's not that hard, right?

Thanks,

	tglx