Re: [PATCH 2/2] spi: Introduce new driver for Qualcomm QuadSPI controller

[Doug Anderson]

Hi,

On Thu, Jul 5, 2018 at 2:46 PM, Girish Mahadevan <girishm@xxxxxxxxxxxxxx> wrote:
> New driver for Qualcomm QuadSPI(QSPI) controller that is used to
> communicate with slaves such flash memory devices. The QSPI controller
> can operate in 2 or 4 wire mode but only supports SPI Mode 0 and SPI
> Mode 3. The controller can also operate in Single or Dual data rate modes.
>
> Signed-off-by: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> ---
>  drivers/spi/Kconfig         |   7 +
>  drivers/spi/Makefile        |   1 +
>  drivers/spi/spi-qcom-qspi.c | 728 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 736 insertions(+)

I spent a few days poking at this driver and trying to see if I could
get it to do anything other than crash and corrupt memory.  I finally
was able to do so.  I've posted my diffs at:

https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6670275e22b5901a1c4c11982cdafd10c2820771%5E%21/#F0

...if it's helpful I'm happy to post a full patch here too (just let
me know), but I'd just expect my patch to get squashed into the next
version and it can be reviewed then.

With my patch applied my testing on sdm845 on a device that can only
support dual SPI seems to work pretty well.  NOTE: as I reply to this,
I realized that I hadn't gone back and tried to address Mark and
Boris's comments.  Some of them are handled because I found the same
problem that they did, but before re-posting you should definitely
handle them.


-Doug