Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

From: Dan Carpenter
Date: Tue Jul 17 2018 - 06:13:49 EST


On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@xxxxxxxxxx>
>
> Return right away instead of break out of while and then return.
>

You could remove the (retries == max_retries) condition since that's
always true now and pull that code in one tab. You could do it in one
patch because they're closely related so it's One Thing [tm].

regads,
dan carpenter