Re: [PATCH v2 00/12] Add utilization clamping support

[Patrick Bellasi]

On 17-Jul 06:03, Joel Fernandes wrote:
> On Mon, Jul 16, 2018 at 09:28:54AM +0100, Patrick Bellasi wrote:
> >  Documentation/admin-guide/cgroup-v2.rst |  25 +
> >  include/linux/sched.h                   |  53 ++
> >  include/uapi/linux/sched.h              |   4 +-
> >  include/uapi/linux/sched/types.h        |  66 +-
> >  init/Kconfig                            |  63 ++
> >  kernel/sched/core.c                     | 876 ++++++++++++++++++++++++
> 
> While I'm reviewing these patches, I had a quick thought. core.c is already
> 7k+ lines. Based on this diffstat, does it make sense for uclamp to be in its
> own kernel/sched/uclamp.c file?

Good point.

I've added it to core.c because it's logically part of the core
scheduler and we have some calls which are part of the fast path and
thus we want to avoid function calls.

I guess that, provided we can rely on LTOs, we can try to move it into
a separate file. Let see what Ingo and Peter thing about this.

> thanks,
> 
> - Joel

-- 
#include <best/regards.h>

Patrick Bellasi