Re: [PATCH 5/5] ARM: dts: exynos: add tmu aliases nodes

[Krzysztof Kozlowski]

On 17 July 2018 at 21:56, Anand Moon <linux.amoon@xxxxxxxxx> wrote:
> Hi
>
> On 17 July 2018 at 17:59, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>> On 17 July 2018 at 12:12, Anand Moon <linux.amoon@xxxxxxxxx> wrote:
>>> add tmuctrl aliases node for exynos542x
>>
>> Please use full sentence, starting with capital letter and ending with
>> a dot. Also please explain why you need tmuctrl aliases.
>>
>
> As per the [0] Documentation/devicetree/bindings/thermal/exynos-thermal.txt
>
> For multi-instance tmu each instance should have an alias correctly
> numbered in "aliases" node.

Ah, right. However except reading value of alias and storing it, the
driver does not use it later. Maybe this should be just removed.

Best regards,
Krzysztof