Re: [kbuild ack?] Re: [PATCH v6 0/9] x86: macrofying inline asm for better compilation

[Masahiro Yamada]

2018-07-16 6:54 GMT+09:00 Ingo Molnar <mingo@xxxxxxxxxx>:
>
> * Nadav Amit <namit@xxxxxxxxxx> wrote:
>
>> > I ran some limited number of benchmarks, and in general the performance
>> > impact is not very notable. You can still see >10 cycles shaved off some
>> > syscalls that manipulate page-tables (e.g., mprotect()), in which
>> > paravirt caused many functions not to be inlined. In addition this
>> > patch-set can prevent issues such as [1], and improves code readability
>> > and maintainability.
>
> Ok, that's good enough as a benefit, I suppose.
>
>> > Nadav Amit (9):
>> >  Makefile: Prepare for using macros for inline asm
>
> This non-trivial kbuild patch needs an Acked-by from Masahiro.


Sorry for delay.

I've issued Acked-by to 1/9 now.

Thanks.



> Thanks,
>
>         Ingo



-- 
Best Regards
Masahiro Yamada