Re: [PATCH] x86/boot: Fix if_changed build flip/flop

[Masahiro Yamada]

2018-07-16 7:58 GMT+09:00 Ingo Molnar <mingo@xxxxxxxxxx>:
>
> * Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
>> The if_changed kbuild function can only be used once per target. If not
>> it will effectively always trigger, flipping back and forth between the
>> two commands getting recorded. Instead, merge the two commands into a
>> single function to get stable build artifacts (i.e. .vmlinux.cmd).
>>
>> Reported-by: Dirk Gouders <dirk@xxxxxxxxxxx>
>
> What actual symptoms does this bug have?
>
> I.e. it would be nice if the changelog started with such an explanation:
>
>   Dirk Gouders reported that .... <bad stuff happens during kernel build> ...
>   and bisected it back to:
>
>     98f78525371b ("x86/boot: Refuse to build with data relocations")
>
>   The root cause of the bug is that the if_changed kbuild function ...
>
> Or something like that.
>
> Thanks,
>
>         Ingo




Anyway, the code diff looks good to me.

Reviewed-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>



-- 
Best Regards
Masahiro Yamada