Re: [PATCH] mtd: nand/raw: MTD_NAND_BCM47XXNFLASH needs CONFIG_BCMA
From: Miquel Raynal
Date: Wed Jul 18 2018 - 03:50:32 EST
Hi Arnd,
Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Wed, 11 Jul 2018
10:44:46 +0200:
> On Wed, 11 Jul 2018 10:39:44 +0200
> Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> > We already have a dependency on BCMA_NFLASH, which in turn depends on
> > BCMA, but since BCMA is a tristate option and BCMA_NFLASH is bool,
> > we can run into an invalid configuration with MTD_NAND_BCM47XXNFLASH=y
> > and BCMA=m:
> >
> > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.o: In function `bcm47xxnflash_ops_bcm4706_init':
> > ops_bcm4706.c:(.text+0x790): undefined reference to `bcma_chipco_pll_read'
> >
> > Adding the dependency here forces MTD_NAND_BCM47XXNFLASH to only be
> > configured =m here so it can link against the BCMA driver.
> >
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
>
Applied with prefix changed to "mtd: rawnand:".
Thanks,
MiquÃl