Re: [PATCH v4 2/5] rtc: isl1208: add support for isl1219 with tamper detection

[Denis OSTERLAND]

Hi,

Am Mittwoch, den 18.07.2018, 10:13 +0200 schrieb Alexandre Belloni:
> On 10/07/2018 09:44:15+0000, Denis OSTERLAND wrote:
> >Â
> > +	if (id->driver_data == TYPE_ISL1219) {
> > +		rc = ISL1219_REG_EV_EVEN;
> > +		rc = i2c_smbus_write_byte_data(client, ISL1219_REG_EV, rc);
> I'd pass ISL1219_REG_EV_EVEN directly instead of assigning it to rc.
> 
Because of the 80 character limit per row, I thought this:
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = ISL1219_REG_EV_EVEN;
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = i2c_smbus_write_byte_data(client, ISL1219_REG_EV, rc);
would look nicer than that:
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂrc = i2c_smbus_write_byte_data(client, ISL1219_REG_EV,
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂISL1219_REG_EV_EVEN);
Are there any reasons why I should prefer the second one?

Regards Denis

Diehl Connectivity Solutions GmbH
GeschÃftsfÃhrung: Horst Leonberger
Sitz der Gesellschaft: NÃrnberg - Registergericht: Amtsgericht
NÃrnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited.