Re: [PATCH 1/3] mm/page_alloc: Move ifdefery out of free_area_init_core

[Oscar Salvador]

On Wed, Jul 18, 2018 at 10:11:50AM -0400, Pavel Tatashin wrote:
> On 18-07-18 14:47:20, osalvador@xxxxxxxxxxxxxxxxxx wrote:
> > From: Oscar Salvador <osalvador@xxxxxxx>
> > 
> > Moving the #ifdefs out of the function makes it easier to follow.
> > 
> > Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
> 
> Hi Oscar,
> 
> Reviewed-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> 
> Please include the following patch in your series, to get rid of the last
> ifdef in this function.
> 
> From f841184e141b21e79c4d017d3b7678c697016d2a Mon Sep 17 00:00:00 2001
> From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
> Date: Wed, 18 Jul 2018 09:56:52 -0400
> Subject: [PATCH] mm: access zone->node via zone_to_nid() and zone_set_nid()
> 
> zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to
> have inline functions to access this field in order to avoid ifdef's in
> c files.

Hi Pavel

I will! Thanks for the patch ;-)
-- 
Oscar Salvador
SUSE L3