Re: [PATCHv5 04/19] mm/page_alloc: Unify alloc_hugepage_vma()
From: Dave Hansen
Date: Wed Jul 18 2018 - 13:43:13 EST
A grammar error or two is probably OK in these descriptions, but these
are just riddled with them in a way that makes them hard to read.
Suggestions below.
On 07/17/2018 04:20 AM, Kirill A. Shutemov wrote:
> We don't need to have separate implementations of alloc_hugepage_vma()
> for NUMA and non-NUMA. Using variant based on alloc_pages_vma() we would
> cover both cases.
"Using the"
> This is preparation patch for allocation encrypted pages.
"a preparation"
"allocation encrypted pages" -> "allocation of encrypted pages" or
"allocation encrypted pages" -> "allocating encrypted pages" or
> alloc_pages_vma() will handle allocation of encrypted pages. With this
> change we don' t need to cover alloc_hugepage_vma() separately.
"don' t" -> "don't"
> The change makes typo in Alpha's implementation of
"a typo"