Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once

From: Dou Liyang
Date: Thu Jul 19 2018 - 02:48:40 EST


Hi Thomas,

At 07/19/2018 02:25 PM, Thomas Gleixner wrote:
On Thu, 19 Jul 2018, Dou Liyang wrote:
At 07/18/2018 10:22 AM, Pavel Tatashin wrote:
+ (unsigned long)cpu_khz % KHZ);
if (cpu_khz != tsc_khz) {
pr_info("Detected %lu.%03lu MHz TSC",
- (unsigned long)tsc_khz / 1000,
- (unsigned long)tsc_khz % 1000);
+ (unsigned long)tsc_khz / KHZ,
+ (unsigned long)tsc_khz % KHZ);
+ }

this curly brackets can be removed

No. They want to stay, really.

https://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos

The pr_info() is a multiline statement due to the line breaks.


I see, I’ll keep that in mind.

Thanks,

dou