Re: [PATCH v2 2/3] net: add support for nvmem to eth_platform_get_mac_address()

From: Dan Carpenter
Date: Thu Jul 19 2018 - 05:11:15 EST



Maybe it would be simpler as three separate functions:

int of_eth_get_mac_address() <- rename existing function to this
int nvmem_eth_get_mac_address() <- patch 2
int mtd_eth_nvmem_get_mac_address() patch 3

int ret;

ret = of_eth_get_mac_address(dev, mac_addr);
if (!ret)
return 0;
ret = nvmem_eth_get_mac_address(dev, mac_addr);
if (ret == -EPROBEDEFER)
return ret;
if (!ret)
return 0;
ret = mtd_eth_nvmem_get_mac_address(dev, mac_addr);
if (!ret)
return 0;

return -ENODEV;

regards,
dan carpenter