Re: [PATCH v2 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid()

[Pavel Tatashin]

On 07/19/2018 09:40 AM, Michal Hocko wrote:
> On Thu 19-07-18 15:27:37, osalvador@xxxxxxxxxxxxxxxxxx wrote:
>> From: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
>>
>> zone->node is configured only when CONFIG_NUMA=y, so it is a good idea to
>> have inline functions to access this field in order to avoid ifdef's in
>> c files.
> 
> Is this a manual find & replace or did you use some scripts?

I used opengrok:

http://src.illumos.org/source/search?q=%22zone-%3Enode%22&defs=&refs=&path=&hist=&project=linux-master

http://src.illumos.org/source/search?q=%22z-%3Enode%22&defs=&refs=&path=&hist=&project=linux-master

> 
> The change makes sense, but I haven't checked that all the places are
> replaced properly. If not we can replace them later.
> 
>> Signed-off-by: Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>
>> Signed-off-by: Oscar Salvador <osalvador@xxxxxxx>
>> Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>
> 
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>

Thank you,
Pavel